search

TopEFT / topeft

15 stars 24 forks source link

Enforce consistent spacing #352

Closed kmohrman closed 1 year ago

kmohrman commented 1 year ago

This PR adds flake8 to the CI. The PR also applies fixes to many of the topcoffea files in order to fix issues caught by the flake8 test.

In the flake8 job in the CI yaml file, I added several flake8 error codes to ignore (for formatting things that I don't think we want to bother enforcing). I also entirely excluded a few files from the check (these files are quite old and are close to being deprecated, but are unfortunately still used in a few places, so we probably don't want to remove them yet. But if/when we come to the point where we want to build on these files, we might consider rewriting them instead of building the old ones). Eventually it may be useful to specify the error codes and files to ignore via a flake8 config file (instead of writing them all out in the CI yaml file).

Addresses Issue #334

codecov[bot] commented 1 year ago

Codecov Report

Merging #352 (0a52ba9) into technical_improvements (c97eb7e) will decrease coverage by 0.40%. The diff coverage is 51.29%.

@@                    Coverage Diff                     @@
##           technical_improvements     #352      +/-   ##
==========================================================
- Coverage                   34.30%   33.90%   -0.40%     
==========================================================
  Files                          40       40              
  Lines                        6734     6742       +8     
==========================================================
- Hits                         2310     2286      -24     
- Misses                       4424     4456      +32
Flag Coverage Δ
unittests 33.90% <51.29%> (-0.40%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
analysis/topEFT/get_datacard_yields.py 0.00% <0.00%> (ø)
analysis/topEFT/get_yield_json.py 91.66% <ø> (ø)
analysis/topEFT/make_1d_quad_plots.py 60.97% <ø> (-1.82%) :arrow_down:
.../topEFT/make_1d_quad_plots_from_template_histos.py 0.00% <0.00%> (ø)
analysis/topEFT/make_cr_and_sr_plots.py 0.00% <0.00%> (ø)
analysis/topEFT/make_jsons.py 0.00% <0.00%> (ø)
analysis/topEFT/make_skim_jsons.py 0.00% <0.00%> (ø)
analysis/topEFT/missing_parton.py 0.00% <ø> (ø)
analysis/topEFT/parse_datacard_templtes.py 0.00% <0.00%> (ø)
analysis/topEFT/run_sow.py 0.00% <0.00%> (ø)
... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kmohrman commented 1 year ago

@bryates does this PR look ok to be merged into the technical_improvements branch, or would you have any comments?