Closed kmohrman closed 1 year ago
Thanks @abasnet97 for adding the scripts from the 2022 tutorial. @bryates I'm wondering if you could confirm whether or not there are any scripts from the 2021 tutorial (on the tutorials
branch) that you would like to preserve here (unless they're already included in @abasnet97's commits)? The idea would be to remove the tutorials
and topcoffeatutorial2022
after we put anything we want to keep from those branches into the new analysis/training
directory.
The notebook I created for 2022 tutorial was based off of Brent's 2021 notebook, so I don't think Brent's repo might have anything different than mine.
The notebook I created for 2022 tutorial was based off of Brent's 2021 notebook, so I don't think Brent's repo might have anything different than mine.
Sorry for the delay. Right, mine is out of date. I did just add the binder link. We should test it once the branch is merged, because I'm pointing it to master which currently does not have this dir strucutre.
Thanks @bryates and @abasnet97. Ok so at this point we are good to go to merge this branch (into technical_improvements
) and remove the tutorials
and topcoffeatutorial2022
branches?
Thanks @bryates and @abasnet97. Ok so at this point we are good to go to merge this branch (into
technical_improvements
) and remove thetutorials
andtopcoffeatutorial2022
branches?
Yup, I'm happy with this PR. We can merge once the CI is done (though the README change shouldn't really affect it).
Merging #356 (23b30ba) into technical_improvements (7c0cb46) will increase coverage by
0.63%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## technical_improvements #356 +/- ##
==========================================================
+ Coverage 33.89% 34.52% +0.63%
==========================================================
Files 40 39 -1
Lines 6742 6618 -124
==========================================================
Hits 2285 2285
+ Misses 4457 4333 -124
Flag | Coverage Δ | |
---|---|---|
unittests | 34.52% <ø> (+0.63%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR adds a new
training
sub directory to thetopcoffea/analysis
directory where we can store simple examples and scripts from tutorials.