TopEFT / topeft

15 stars 24 forks source link

Change electron name from e to ele in topeft #357

Closed abasnet97 closed 1 year ago

abasnet97 commented 1 year ago

In this simple PR, topeft script has been modified to change all instances of e to ele. To verify that all such instances were changed and there were no issues as a result of this, I ran topeft on some signal samples, and there was no issue producing the pkl file.

codecov[bot] commented 1 year ago

Codecov Report

Merging #357 (3106391) into technical_improvements (7c0cb46) will not change coverage. The diff coverage is 0.00%.

@@                   Coverage Diff                   @@
##           technical_improvements     #357   +/-   ##
=======================================================
  Coverage                   33.89%   33.89%           
=======================================================
  Files                          40       40           
  Lines                        6742     6742           
=======================================================
  Hits                         2285     2285           
  Misses                       4457     4457           
Flag Coverage Δ
unittests 33.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
analysis/topEFT/topeft.py 8.44% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kmohrman commented 1 year ago

Thanks very much @abasnet97, I think this will make it much easier when we have to search for the electron object in the code (as searching for e usually gives way too many matches..), since @bryates has also approved it, I'll go ahead and merge now.

(Also just to link this to the appropriate issue, this PR fixes Issue #339.)