search

TopEFT / topeft

15 stars 24 forks source link

Remove numpy version pin when able #368

Open kmohrman opened 1 year ago

kmohrman commented 1 year ago

Note that we have pinned the numpy version in the environment.yml file (to numpy=1.23.5) as a workaround to the numpy.bool error that we otherwise get (from one of the coffea files). This is implemented in PR #354.

This should be revisited at some point (e.g. once coffea has fixed the numpy.bool instance, or once conda has figured out how to make a consistent environment that does not lead to this error) to remove the numpy version pin.

bryates commented 6 months ago

The numpy.bool issu was addressed in Coffea v0.7.22 https://github.com/CoffeaTeam/coffea/pull/901. We can now unpin numpy.

bryates commented 6 months ago

There are still some issues with our repo and numpy, so I'm reopening this for later. (see https://github.com/TopEFT/topeft/pull/405)

bryates commented 3 months ago

Now there is an issue with numpy 2.0, so we'll have to keep this a bit longer. Hopefully the calendar coffea transition will eventually remove the need to pin numpy.