Fix Lint errors for `type()`

bryates commented 1 year ago

Replaced type(x) == y with isinstance(x, y)

codecov[bot] commented 1 year ago

Codecov Report

Merging #372 (b62397d) into master (501fd5d) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files          40       40           
  Lines        6550     6550           
=======================================
  Hits         2156     2156           
  Misses       4394     4394

Flag	Coverage Δ
unittests	`32.91% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
topcoffea/modules/YieldTools.py	`42.51% <100.00%> (ø)`
topcoffea/modules/dataDrivenEstimation.py	`67.88% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kmohrman commented 1 year ago

@bryates this looks fine to me and it's passing the CI so I'm happy for it to be merged. Did you want me to, or do you want to?

bryates commented 1 year ago

@bryates this looks fine to me and it's passing the CI so I'm happy for it to be merged. Did you want me to, or do you want to?

I'll merge it now.

TopEFT / topeft

Fix Lint errors for `type()` #372

Codecov Report