TopEFT / topeft

15 stars 24 forks source link

Move PU corrections to topcoffea #389

Closed kmohrman closed 8 months ago

kmohrman commented 8 months ago

In this PR:

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (80bfc08) 28.12% compared to head (5803830) 27.17%. Report is 1 commits behind head on master.

Files Patch % Lines
analysis/topeft_run2/analysis_processor.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #389 +/- ## ========================================== - Coverage 28.12% 27.17% -0.96% ========================================== Files 29 28 -1 Lines 4849 4224 -625 ========================================== - Hits 1364 1148 -216 + Misses 3485 3076 -409 ``` | [Flag](https://app.codecov.io/gh/TopEFT/topeft/pull/389/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TopEFT/topeft/pull/389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | `27.17% <66.66%> (-0.96%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kmohrman commented 8 months ago

Ok, thanks Brent. I've rerun the CI after merging the topcoffea PR as you suggested, and it indeed passes. So I'll go ahead and merge now.