search

TopEFT / topeft

15 stars 24 forks source link

Move scale weights to tc #390

Closed kmohrman closed 8 months ago

kmohrman commented 8 months ago

Move the code for getting reform/fact and ISR/FSR weights to topcoffea. (Note the topcoffea PR 18 will have to be merged before the CI passes here).

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b315b9b) 27.17% compared to head (49a8702) 27.17%.

Files Patch % Lines
analysis/topeft_run2/analysis_processor.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #390 +/- ## ======================================= Coverage 27.17% 27.17% ======================================= Files 28 28 Lines 4224 4224 ======================================= Hits 1148 1148 Misses 3076 3076 ``` | [Flag](https://app.codecov.io/gh/TopEFT/topeft/pull/390/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TopEFT/topeft/pull/390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | `27.17% <33.33%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryates commented 8 months ago

The CI passed, so I'll merge this.