search

TopEFT / topeft

15 stars 24 forks source link

Uploading latest Tau SF functions #408

Closed anpicci closed 4 months ago

anpicci commented 7 months ago

This PR updates the tau SF implementation to the latest version available

bryates commented 7 months ago

@anpicci please fix the lint errors

anpicci commented 7 months ago

Ok, which solution do you prefer @bryates ?

bryates commented 7 months ago

Ok, which solution do you prefer @bryates ?

I'm leaning towards updating the CI to checkout the temporary branch, so we can get it all running and maybe merge now. That does of course mean we'll have to fix it again later. @Andrew42 and @sscruz what do you think?

anpicci commented 5 months ago

I was wondering if there is any update on this @bryates

bryates commented 5 months ago

I was wondering if there is any update on this @bryates

@anpicci while we're waiting for the TopCoffea PR, can you fix these lint errors? https://github.com/TopEFT/topeft/actions/runs/8706515199/job/23879255324?pr=408#step:4:32 It looks like just 2 lines with blank spaces at the end.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.83%. Comparing base (a2beb1e) to head (fe9042d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #408 +/- ## ======================================= Coverage 26.83% 26.83% ======================================= Files 31 31 Lines 4572 4572 ======================================= Hits 1227 1227 Misses 3345 3345 ``` | [Flag](https://app.codecov.io/gh/TopEFT/topeft/pull/408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TopEFT/topeft/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | `26.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anpicci commented 4 months ago

@bryates no, I don't need to add anything else, thanks!

anpicci commented 4 months ago

hi @bryates , do you think we can merge?

bryates commented 4 months ago

hi @bryates , do you think we can merge?

I wanted to make sure @andrea21z and @sscruz don't have any comments, but I'm happy with this PR.

anpicci commented 4 months ago

I'm afraid @andrea21z is not working for CMS anymore

bryates commented 4 months ago

I'm afraid @andrea21z is not working for CMS anymore

I meant @Andrew42 😂