Closed bryates closed 5 months ago
Attention: Patch coverage is 82.14286%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 26.27%. Comparing base (
838b7c9
) to head (3f6bff9
).
Files | Patch % | Lines |
---|---|---|
analysis/topeft_run2/analysis_processor.py | 50.00% | 3 Missing :warning: |
topeft/modules/datacard_tools.py | 86.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok, after the changes you made to my comments, I think I'm good with having this PR merged.
This PR addresses https://github.com/TopEFT/topcoffea/issues/27. Instead of altering how
histEFT
works, it is simpler to just have a separate histogram for storing the sum of the square of the weights. This will be part of thenew_histEFT
update, but I wanted a separate PR to make the review easier.