search

TopEFT / topeft

15 stars 24 forks source link

Photon datacard #420

Open bryates opened 3 months ago

bryates commented 3 months ago

This PR updates the datacard maker to handle the new ttgamma process. This is based on the datacard maker from the master branch, so it looks like a lot more changes than there actually are.

bryates commented 3 months ago

This PR is pretty simple, but the CI is failing since we've changed the channels upstream in the analysis processor. I don't think that should hold up this PR, since it's targeting the photon branch. @Andrew42 and @abasnet97 did either of you have comments on this PR?

abasnet97 commented 3 months ago

To me, the PR looks good. I think Brent said that the photon related changes were pretty simple and were added on top of pre-exisiting changes made in the master branch (which have been verified to work).

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.69%. Comparing base (da40fc5) to head (b85714b).

Files Patch % Lines
topeft/modules/datacard_tools.py 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## photons_histEFT #420 +/- ## =================================================== + Coverage 24.68% 24.69% +0.01% =================================================== Files 35 35 Lines 5015 5017 +2 =================================================== + Hits 1238 1239 +1 - Misses 3777 3778 +1 ``` | [Flag](https://app.codecov.io/gh/TopEFT/topeft/pull/420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TopEFT/topeft/pull/420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | `24.69% <71.42%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.