search

TopEFT / topeft

15 stars 24 forks source link

Ch update histeft #431

Open jlawrenc opened 2 months ago

jlawrenc commented 2 months ago

This change modifies the topeft_run2 analysis processor and supporting scripts. The key change in the channel definitions are moved to a json as a common source for the scripts to draw upon. It also includes two new run modes the onZ/offZ channels and tau channels. The TOP-22-006 run mode has been fully validated to the data and asimov limits. The tau and onZ/offZ run modes are still undergoing final validation

bryates commented 2 months ago

Thanks @jlawrenc. Is this branch in sync with the latest master updates? I see some merge conflicts.

jlawrenc commented 2 months ago

It does appear there are a couple merge conflicts we were unaware of. It looks like they are due to some recent tau changes so I will resolve them before a merge

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 4.06504% with 236 lines in your changes missing coverage. Please review.

Project coverage is 25.70%. Comparing base (3d3ad9d) to head (f59d265).

Files with missing lines Patch % Lines
analysis/topeft_run2/analysis_processor.py 2.61% 186 Missing :warning:
analysis/topeft_run2/datacards_post_processing.py 0.00% 46 Missing :warning:
analysis/topeft_run2/run_analysis.py 55.55% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #431 +/- ## ========================================== - Coverage 26.58% 25.70% -0.88% ========================================== Files 31 31 Lines 4612 4812 +200 ========================================== + Hits 1226 1237 +11 - Misses 3386 3575 +189 ``` | [Flag](https://app.codecov.io/gh/TopEFT/topeft/pull/431/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TopEFT/topeft/pull/431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT) | `25.70% <4.06%> (-0.88%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TopEFT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anpicci commented 2 months ago

@bryates we have just created a PR in topcoffea to include an addition for the offZ analysis https://github.com/TopEFT/topcoffea/pull/44

bryates commented 2 weeks ago

@jlawrenc how is this PR coming along?