Closed supermaxiste closed 1 year ago
Hi and thanks for your contribution. I honestly never had an opportunity to work with docker so far and cannot really comment on it, but I trust you have tried it out and are happy with it. Assuming you will be able to field questions and maintain this feature in the future, I'd be happy to accept your PR into master, OK?
Hi Holger,
I confirm that the Dockerfile
has been tested and we're happy with it. For any questions or issues, my colleagues and I will make sure to address them. In principle it should be mostly usage questions and to ensure that the Dockerfile
is updated with the latest version of this tool, we'll open a separate PR to automate the process.
Ok thanks. Let's go.
Dear Holger,
your SHACL API tool is very nicely implemented and this PR includes a Dockerfile to make the tool even more accessible. The Dockerfile includes a multi-stage build to ensure that only a minimal Java environment is created to support Jena for the SHACL API. To find out about the minimal requirements, the Apache Jena developers provided all the information and tools needed for this task.
The current
Dockerfile
creates an image of 144Mb, making it relatively lightweight. ThisDockerfile
is linked to anentrypoint.sh
script to call eithershaclvalidate.sh
orshaclinfer.sh
with the commandsvalidate
andinfer
respectively. I modified the README to explain the usage as follows:Dockerfile Usage
The
Dockerfile
in the.docker
folder includes a minimal Java Runtime Environment for the SHACL API that clocks in at 144Mb. To build the docker image use:To use the Docker image, there are two possible commands. To run the validator:
To run rule inferencing:
Any other command after
topquadrant/shacl:1.4.2
will print the following help page:The current PR would already be a fully working Docker solution for
shacl-1.4.2
, but there could be another major improvement to this. If the container is made available on DockerHub by TopQuadrant, it would be possible to write a GitHub Action to automatically build and push an image for every new release ofshacl
. My colleagues and I from the Swiss Data Science Center - Open Research Data would be glad to further contribute as we'll be usingshacl
moving forward.