search

TopQuadrant / shacl

SHACL API in Java based on Apache Jena
Apache License 2.0
217 stars 61 forks source link

Update Jena to 4.6.1, and slf4j to 1.7.36 #154

Closed lolgab closed 9 months ago

lolgab commented 1 year ago

Didn't update to latest because Jena 4.7.0 removed RecursiveElementVisitor and I don't know how to replace it yet. I think we can split the update in two steps. First merging this PR and then updating to 4.8.0 in a separate one. I also updated to the latest patch release of slf4j 1.7.

Opened an issue here

HolgerKnublauch commented 1 year ago

We have an internal branch under review to update our product to Jena 4.8 and I will compare how much work it will be to hand-pick the changes into the open source project, likely this week.

lolgab commented 1 year ago

Any updates @HolgerKnublauch ?

HolgerKnublauch commented 1 year ago

Sorry, I am too busy right now and should probably hand this project over to someone else. It has diverged too much from what we use in our product and I am not seeing enough benefits to maintain it further at the moment.

afs commented 1 year ago

From apache/jena/issues/1887 :

RecursiveElementVisitor is a do-nothing class that wasn't being used in Jena. The contract wasn't getting maintained.

Ideally, use a regular ElementVisitor. The SHACL code is all "startElement" calls so it looks like ElementVisitor.visit will work.

Otherwise, take a copy of the code.

lolgab commented 1 year ago

Sorry, I am too busy right now and should probably hand this project over to someone else. It has diverged too much from what we use in our product and I am not seeing enough benefits to maintain it further at the moment.

Any chance your new SHACL implementation will be open-sourced?

HolgerKnublauch commented 1 year ago

Any chance your new SHACL implementation will be open-sourced?

No, because that depends on quite some code that is outside of the open source project.

asajim commented 9 months ago

@HolgerKnublauch any update?

HolgerKnublauch commented 9 months ago

@asajim no I have no time for major work on this API right now. I welcome PRs.

asajim commented 9 months ago

@HolgerKnublauch I understand. Can you approve this PR then? or is there an issue that we have to address first?

HolgerKnublauch commented 9 months ago

Fine. Did it pass the test cases?

asajim commented 9 months ago

@HolgerKnublauch yes it does. I've tested in my own project as well

asajim commented 9 months ago

@HolgerKnublauch can you release new version (1.4.3) please?