search

TopQuadrant / shacl

SHACL API in Java based on Apache Jena
Apache License 2.0
217 stars 61 forks source link

Pushed Jena version to 5.0.0 and updated Caching library #177

Open jerdebsp opened 4 months ago

jerdebsp commented 4 months ago

Hi,

I was having trouble using 1.4.3 due to Jena classes deprecated or removed - more specifically org.apache.jena.graph.Factory. In my pull request, i've updated Jena to the latest version and also updated the Caching library to use benmanes (https://github.com/ben-manes/caffeine) which is compatible with the previously used library. I believe that the library used in the main fork is not available anymore.

Thanks, Jeremy

PS. I couldn't assign anyone as reviewer. I guess Holger or Ashley can do this.

costas80 commented 3 months ago

Hey @jerdebsp . Is this PR blocked? I see discussion about a stack overflow from the review by @afs but no clear resolution.

jerdebsp commented 3 months ago

That comment was for why I did not use JenaUtil.createDefaultGraph(). I think the PR is still blocked for now until Java (on the CI) is updated from 17 to 21 or 22.

If you are using java 21 or 22, you can download my branch and use it. I am using it for project work and training and so far it seems to work well