Unknown argument "words" for filter "hacksaw(unit, limit, allowed_tags, append)"

TopShelfCraft / Wordsmith-Docs

Documentation for the Wordsmith plugin — https://wordsmith.docs.topshelfcraft.com

3 stars 3 forks source link

Closed shantamg closed 6 years ago

shantamg commented 6 years ago

I had been using the hacksaw plugin with Craft 2 and was doing this:

hacksaw(words='30')

After upgrading to Craft 3 and installing Wordsmith, Craft raises raises an unknown argument error. It's an easy fix, just need to change it to

hacksaw(unit='words', limit='30')

but I thought I'd mention it because this a case where Wordsmith is not backwards compatible with hacksaw.

michaelrog commented 6 years ago

Thanks for catching this! We should definitely add some param normalization there for backwards compatibility.

shantamg commented 6 years ago

Am I correct that you have not made the source public? Can't find it anywhere otherwise I would have opened the issue there and perhaps done a PR.

michaelrog commented 6 years ago

Doh, I didn't realize this Issue is on the documentation repo. Have re-created the issue over on the plugin repo: https://github.com/TopShelfCraft/Wordsmith/issues/2

Sorry for the confusion!