search

TopShelfCraft / Wordsmith

A plugin for Craft CMS to help you manage and manipulate text.
Other
30 stars 20 forks source link

Dependency erusev/parsedown-extra with PSR-0 issues #43

Closed ostark closed 3 years ago

ostark commented 3 years ago

Not your issue, but still an issue:

https://github.com/erusev/parsedown-extra/issues/156

michaelrog commented 3 years ago

Grumpgrumpgrump. Thanks for calling that to my attention.

peteeveleigh commented 3 years ago

Looks like there was a pull request for this made in the erusev/parsedown-extra package but it's been sitting there since May 2020. Not sure what can be done from here without forking it and fixing the problem. Doesn't look like the author is interested in it any longer.

michaelrog commented 3 years ago

From the POV of Wordsmith, it looks like a mostly aesthetic issue... i.e. Composer is complaining about invalid namespacing for ParsedownExtraTest, but that class isn't used invoked by Wordsmith. So as far as I know, it's not breaking any of the plugin's functionality. Am I missing something?

ostark commented 3 years ago

Depends if your FS is case sensitive or not. Previously Composer wasn't strict about casing, now with 2.0 it is. Composer doesn't know if you will use the class later. To avoid surprises later, it makes sense to complain about it.

peteeveleigh commented 3 years ago

@michaelrog if you are using Composer 2 and running composer install on deployment then it can fail with an error and not do the autoload thing. I will double check it though. Maybe it won't be a problem as it will only skip that particular class

michaelrog commented 3 years ago

yeah, I'm using Composer 2, but I just see warnings, and it installs just fine.

ostark commented 3 years ago

I suggest to fork it since further development by maintainer is unlikely. Or use a different package.

michaelrog commented 3 years ago

For sure — Will probably ditch Parsedown Extra altogether in 4.0, and just use GFM via The League's package.

Also want to fix any breaking issues in 3.x, so just trying to confirm if this present issue is, in fact, "breaking" (as opposed to just annoying).

peteeveleigh commented 3 years ago

On reflection I don’t think it’s breaking.

On 12 Feb 2021, at 17:08, Michael Rog notifications@github.com wrote:

For sure — Will probably ditch Parsedown Extra altogether in 4.0, and just use GFM via The League's package.

Also want to fix any breaking issues in 3.x, so just trying to confirm if this present issue is, in fact, "breaking" (as opposed to just annoying).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TopShelfCraft/Wordsmith/issues/43#issuecomment-778320450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJ5OP2HZANXSQDXD3CXADS6VOBBANCNFSM4U6TK53Q.

ademers commented 3 years ago

I've just noticed this today:

Deprecation Notice: Class ParsedownExtraTest located in ./vendor/erusev/parsedown-extra/test/ParsedownExtraTest.php does not comply with psr-0 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

Can someone please confirm that this won't bork my Production env. when I finally upgrade to Composer 2? Thanks!

michaelrog commented 3 years ago

@ademers — should be fine. The ParsedownExtraTest class isn't required for any functionality, so it's not concerning that it doesn't get loaded by Composer 2. (In the next version, I'll probably just remove the dependency, cuz nobody likes to be pestered.)