TopShelfCraft / Wordsmith

A plugin for Craft CMS to help you manage and manipulate text.
Other
30 stars 20 forks source link

Add `encode` parameter to `markdown` & `md` filters #57

Closed j-add closed 9 months ago

j-add commented 9 months ago

Craft v4.5.13 introduces a change to markdown and md filters, giving them an encode parameter. CP templates have been updated to use this functionality. This results in a Twig Syntax Error being thrown when the unknown argument (encode) is passed to the filter.

Error encountered on admin/utilities/deprecation-errors page.


Relevant commit

DynamiteGoesBoom commented 9 months ago

I'm running into this same issue.

DynamiteGoesBoom commented 9 months ago

Looks like reverting to 4.5.11.1 fixes it

scandella commented 9 months ago

Reverting to 4.5.12 works fine too.

michaelrog commented 9 months ago

Thanks for calling this in. At the very least, I'll adjust the plugin to prevent overriding those filters in the cp template mode.

michaelrog commented 9 months ago

✅ Wordsmith 4.4.0 is out with a change to avoid conflicting w/ Craft's filters in the CP.

Wordsmith's markdown and md are now deprecated, and I'll remove them in Wordsmith 5.0, since Craft now provides this functionality natively.