Dependency issue causing CI to fail

TopShelfCraft / Wordsmith

A plugin for Craft CMS to help you manage and manipulate text.

Other

30 stars 20 forks source link

Dependency issue causing CI to fail #59

Closed thatONEjustin closed 4 months ago

thatONEjustin commented 7 months ago

How to reproduce:

Install plugin on craft 4.7.1
run composer install

Class ParsedownExtraTest located in ./vendor/erusev/parsedown-extra/test/ParsedownExtraTest.php does not comply with psr-0 autoloading standard. Skipping.

erusev/parsedown-extra hasn't been updated in 5 years. Should be moved away from.

michaelrog commented 4 months ago

Yeah, this has been an annoyance.

I intend to remove Parsedown support (and this dependency) in 5.x. (In fact, given that Craft's native markdown filter supports more flavors, I'll probably remove Markdown parsing from Wordsmith altogether.)

For 4.x — for now, at least — you'll need to suppress that Composer warning, so that your CI can proceed.

(I imagine it may be possible to use a Composer patch to remove or modify this offending test file; I'd welcome a PR for that.)

michaelrog commented 3 months ago

Wordsmith 5.0.0 is out now for Craft 5, removing erusev/parsedown-extra. ✅