Fix popups disappearing

Toparvion / analog

🔎 Flexible web-based real-time log viewer

MIT License

19 stars 5 forks source link

Fix popups disappearing #37

Closed Toparvion closed 4 years ago

Toparvion commented 4 years ago

Fixes #26 .

Changes summary:

Do not rely on the result of endpoints' toString() method anymore
Instead, use ContainerTargetFile as the provider of information about event source
Fix log levels in LocalizedLogger

Toparvion commented 4 years ago

The problem was in TailEventHandler#processFileTailingEvent method, which used to extract the event source's log path from toString() method of the corresponding bean (please don't ask me why 😄). From now on it uses ContainerTargetFile#getAbsolutePath method whose result is controlled by our preceding logic (for example see TailingFlowProvider#newTailAdapter4Docker method) and thus should be protected from changes in upcoming versions of frameworks.

Toparvion commented 4 years ago

I asked our teammates to check the fix in their AnaLog deployment. Will proceed with this PR when they reply.

Toparvion commented 4 years ago

Out teammates reported they don't see any changes to the popups' behavior. Will investigate it further...

Toparvion commented 4 years ago

Found the source of the reported problem and fixed it. Waiting for the feedback again.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

88.9% Coverage
0.0% Duplication

Toparvion commented 4 years ago

So, I've finally fixed the problem and eventually added unit tests to the TailEventHandler (thanks to SonarCloud that forced me to do it). This issue appeared to be not so simple as it seemed at the beginning. Nonetheless we've fixed it. Another good experience 🙂