search

Topener / nl.fokkezb.pullToRefresh

Widget to implement a table pull-to-refresh header in Titanium Alloy
184 stars 60 forks source link

use unified Ti.UI.createRefreshControl API for iOS & Android #75

Open 0x6e69636f opened 6 years ago

0x6e69636f commented 6 years ago

I just removed the if(OS_IOS) and if(OS_ANDROID) tests and Android specific code because since this change, we can now use Ti.UI.createRefreshControl on both platform

See 6.2.0.GA changelog

of course I invite you to test this, since I just made the fix and am testing this on my app, working fine so far

Topener commented 6 years ago

Thanks!

However, I want to deprecate this widget in general, but it needs to be kept as-is for scrollview as that is the only thing not supported right now in Titanium 6.2 on Android

Next to that, setting the text can be done manually easily with the current implementation by using getControl and putting the text on it like that. However this implementation is cleaner of course.

Let me know what you think

0x6e69636f commented 6 years ago

Hey, thanks for my late reply As you want, I guess it can be cool to just maintain the widget for simple implementation and retro-compatibility (my case) I haven't been deep in the widget's code, I just found how to fix this and found it pretty easy to use to implement a pull to refresh on a list