IMPORTANT: Checklist before committing / pull-request:
[x] IMPORTANT: Please read this checklist and checkmark the items, putting [x] at the beginning of the bullet-point
[x] Think of the reviewers and make their life easier :) while also keeping You reputation good by committing high-quality code and avoiding bad-quality commits
[x] Self-review before committing, with graphical diff (e.g. IDE), ideally with per-character diff highlight.
[x] Provide descriptive commit message, pull-request titles and branch names, including issue number in commit message, e.g. #123
[x] Proper indentation. Two spaces in Angular.
[x] Use spell-checker built into Your IDE
[x] Please avoid compiler warnings or tslint / codelyzer / IDE warnings
[x] Run unit tests npm test and TestCafe cd e2e-testcafe ; npm i && npm test
[x] Check Continuous Integration (CI) build status (takes about 1m30s)
[x] Small files / modules / classes / methods / components (single responsibility principle). Even if a given thing seems like it will not be re-used, it should be split off, for the sake of making it easier to analyse it (and maybe it will actually be reused in the future or a new implementation will be developed / experimented-on in the future)
[x] Please don't put random changes in pull-requests, e.g. reformatting entire files, changing quotes to double/single, etc. For the sake of easier reviewing and not polluting git annotate
[x] Please follow platform / language / library style guide
camelCaseVariableNames
CamelCaseClassNames
[x] Avoid duplicate code. Do not copy-paste ~2 or more lines. Instead, extract component / class / method and reuse in all places. For the sake of future maintenance.
[x] Tested on mobile resolutions. Manually and via cd e2e-testcafe ; npm i && npm test:all
IMPORTANT: Checklist before committing / pull-request:
[x]
at the beginning of the bullet-pointnpm test
and TestCafecd e2e-testcafe ; npm i && npm test
git annotate
cd e2e-testcafe ; npm i && npm test:all