search

TopoToolbox / pytopotoolbox

Python interface to TopoToolbox
https://topotoolbox.github.io/pytopotoolbox/
GNU General Public License v3.0
1 stars 2 forks source link

Handle PyBind11 License #20

Closed Teschl closed 2 months ago

Teschl commented 2 months ago

Since PyBind11 is using a BSD-style license that, among other things, states:

"2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution." from pybind11 license

Does that mean we also have to include the license in our repository? If so, we'll probably need to check all other dependencies for similar requirements.

wkearn commented 2 months ago

I think you are probably right: we need to provide the pybind11 license somewhere in the package that we ship to users. It seems like scipy does this with a separate LICENSES_bundled.txt that includes the license for all of their dependencies, which seems like a good enough solution for the moment. I'll submit a PR momentarily with that file.

I think pybind11 is the only one we need to worry about at the moment because we don't distribute source or binary artifacts of any of the other dependencies (matplotlib, rasterio, etc.). pip pulls those in for the user.