Provide example data

[Teschl]

In this pull request, I added the following functions:

• topotoolbox.load_dem() enter DEM name as argument, it will download the tif if it isn't already cached.
• topotoolbox.get_dem_names() will return a list of all available tifs for load_dem(). if we add a .txt which contains all names to the repository which contains the tifs, we can implement it more dynamically. (right now it's just a list in the .py file)
• topotoolbox.read_tif() is a wrapper for creating a GridObject. Could be a cleaner way to create a GridObject inspired by pandas (pandas.read_csv creates a pandas.Dataframe).

Since the function get_save_location() in utils.py is not listed in __all__ it's not automatically imported when using the package. This way it's "private" and not usable for the user by default.

I also fixed some line length issues in the mixin files for the GridObject. The maximum line length is 79 chars.

[Teschl]

Regarding the repository that contains the examples, right now, it's the https://github.com/wschwanghart/DEMs repository. So we might want to fork it to https://github.com/TopoToolbox/DEMs. Then we also should add a file like contents.txt in which we store all names of the provided DEMs. That means we could remove the hardcoded DEM_NAMES of utils.py and generate them dynamically.

If implemented, this should resolve #9 .

[wkearn]

https://github.com/TopoToolbox/DEMs

[wschwanghart]

Excellent. I think it's generally a good idea to host also the example DEMs on git although git is not really made for data hosting. However, so far it supports file sizes up to 50 Mb. We might also consider this here: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-git-large-file-storage

Am Di., 28. Mai 2024 um 19:57 Uhr schrieb William Kearney < @.***>:

https://github.com/TopoToolbox/DEMs

— Reply to this email directly, view it on GitHub https://github.com/TopoToolbox/pytopotoolbox/pull/29#issuecomment-2135823260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RU3DYTAE46OS3KWBL3GDZETASNAVCNFSM6AAAAABIM4D7ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVHAZDGMRWGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[Teschl]

I have addressed the more bug-fix related requested changes.

Would it make sense to read the data through rasterio in here and then use read_tif in the GridObject constructor? That might let us use the GridObject constructor to dispatch to different methods for loading data depending on the arguments provided to it. That might be a problem for another pull request though.

and maybe adding store_dem() can be handled in a different pull request.