Toporin / Seedkeeper-Tool

Windows, Linux & Mac GUI application to use a Seedkeeper (seedkeeper.io)
GNU Lesser General Public License v3.0
7 stars 3 forks source link

Mnemonic wizard: incorrect seed derivation during plaintext import to a satochip #12

Closed Toporin closed 7 months ago

Toporin commented 7 months ago

Description

When importing a (BIP39) mnemonic from the SeedKeeperTool wizard to a Satochip card (in plaintext), the mnemonic type is not identified correctly, and the wrong seed derivation algorithm (the one normally used for Electrum mnemonic). Consequently the addresses derived from the seed are not compatible with standard BIP39 as expected.

In summary, the SeedKeeperTool wizard derives BIP39 seeds using the Electrum algorithm.

Credits

Thanks to Telegram user Max Max for finding the bug and to @3rdIteration for confirming and reproducing the issue!

Toporin commented 7 months ago

fixed in https://github.com/Toporin/Seedkeeper-Tool/commit/f3eefb4ef87df010e96018845a8985cdb9532946

Toporin commented 7 months ago

A python script has been released to recover a wallet affected by this issue (wallet derived from a BIP39 seed with the incorrect derivation algorithm): https://github.com/Toporin/SeedkeeperTool-patch12