Toporin / Seedkeeper-iOS

iOS app to use Seedkeeper on an iPhone. Backup and recover your most precious secrets with a tap on your phone!
GNU General Public License v3.0
2 stars 1 forks source link

[Bug] PIN handle not working #34

Closed Bastien-Satochip closed 1 month ago

Bastien-Satochip commented 3 months ago

Typically, when you provide a wrong PIN 4 times, the card get blocked. Here, with the mobile app, there is no such check.

First issue:

msg531914946-233987

image

Second issue:

Please update this process to make it more clear. If the card give a "blocked" status back, the user should be notified through -either a pop up - or the NFC toast message - that the card is blocked.

image

Toporin commented 2 months ago

The issue is not completely solved:

Correct: When a wrong PIN is entered, a message showing wrong PIN with number of remaining tries is displayed

However, when the card is blocked the message "wrong PIN code" is shown instead of "Too many wrong PIN! Card is blocked." When number of PIN remaining is 0, the message "Too many wrong PIN! Card is blocked." should be shown.

photo_5868321822523638481_y photo_5868321822523638482_y photo_5868321822523638483_y photo_5868321822523638484_y photo_5868321822523638485_y

Bastien-Satochip commented 1 month ago

Tested and fixed.