search

ToranSharma / Duo-Strength

Browser extension to add back the strength for each individual skill, and other useful hidden statistics.
MIT License
35 stars 6 forks source link

Suggestion: hide skills above certain level #190

Closed alexseyk closed 3 years ago

alexseyk commented 3 years ago

Hi

The idea is to avoid scrolling down the page to the currently studied skill, so an option to hide skills above certain (user defined) level is desired .

I think i saw an extension (script) to hide level 5 skills somewhere ( It may be outdated since there are L6 skills now) and it is not as versatile as desired. (i.e. for trees with lower levels )

Proposed option should work in combination with "show only skills that need attention"

UPD: I guess "Skill Suggestion" serves the same function :) but not so visual . Still it is a workable workaround :) cheers

ToranSharma commented 3 years ago

This is possibly also a better solution than the mastered skills list for what is being discussed in #192.

I suppose the main consideration here is, as you said, how it should interact with the existing "Show Only Skills that Need Attention" feature. Having this new hiding feature work irrespective of the strength and cracked state of the skills means that it is somewhat incompatible with the existing skill hiding feature as the hidden skills might need attention.

Having this as a completely separate feature would also be a change in approach the extension has towards skill strength. While this is entirely valid and can easily be done, it does feel very separate from the rest of the extension which is based around adding back the strength information for added spaced repetition. This is of course not exclusively true, features like the XP, Crowns and Languages info boxes are all useful independently from the strength system.

Here are the options as far as I see it: 1) Mastered skill feature is extended to have more behaviours than just marking individual skills. E.g. Mark all L5 skills as mastered, thus they will never need attention and be hidden. 2) Separate skill hiding feature for users who are not interested in the strength of skills. E.g. similar to the other extension you mentioned. 3) New way of jump downing to the area of the tree that is currently being worked on. Essentially the open skill popout button for the skill suggestion, but without opening the popout and maybe customisation of where it jumps to. 1) Button near the top of the tree to do this 2) Hotkey that can be hit to do the jump 3) Both a button and hotkey.

Any thoughts on the above?

Toran

ToranSharma commented 3 years ago

I think at least for the time being I am going to go with option 1. This is most inline with what is need to sort out #192.

Here is the new option with the different behaviours for what to consider as 'Mastered'. Mastered Criterion Option

If the the threshold option is selected, the sub option is added. Mastered Threshold Option

ToranSharma commented 3 years ago

These options and handling have been added in 6565730.

ToranSharma commented 3 years ago

I have added some sub options to specify a separate threshold value for grammar skills in 69f72a2. image

ToranSharma commented 3 years ago

I have released these new options in v2.0.17, which has just been uploaded.

Let me know if there are any issues.

Toran