Support PHP8 - Githubissues

Torann / laravel-currency

This provides Laravel with currency functions such as currency formatting and conversion using up-to-date exchange rates.

http://lyften.com/projects/laravel-currency

BSD 2-Clause "Simplified" License

393 stars 136 forks source link

Closed repat closed 3 years ago

repat commented 3 years ago

composer update works with PHP8
There are no tests, so phpunit "works" too
Looked through some code manually but didn't find anything that would cause problems on PHP8
./vendor/bin/phpstan --level=0 --no-progress analyse src works without problems
./vendor/bin/phpcs --standard=phpcs.xml src works without problems => as expected, nothing more was needed to support PHP 8

repat commented 3 years ago

@Torann could you merge this please :)

repat commented 3 years ago

Package seems abandoned, he doesn't answer emails either.

Will fork and release under https://github.com/repat/laravel-currency -> repat/laravel-currency

Torann commented 3 years ago

I was on vacation for a while

Torann commented 3 years ago

Ah you changed the package name...oh well :-)

repat commented 3 years ago

Yea sorry, figured after opening a ticket on Nov 30th and a PR a month ago and no reply I take matter into my own hands 😅