Fixed Laravel Coding Style

Torann / laravel-currency

This provides Laravel with currency functions such as currency formatting and conversion using up-to-date exchange rates.

http://lyften.com/projects/laravel-currency

BSD 2-Clause "Simplified" License

392 stars 137 forks source link

Fixed Laravel Coding Style #20

Closed billmn closed 9 years ago

billmn commented 9 years ago

Fixed Laravel Coding Style and a missing "return" in getCurrencySymbol()

piotr-cz commented 9 years ago

+1, this is important for contributors to easily pick up the code.

tjbenator commented 9 years ago

+1 for coding style :)

http://laravel.com/docs/4.2/contributions#coding-style

Torann commented 9 years ago

Everything in the pull request looks great. I did this back before I started following the coding style more closely. My only reason for not merging the request is the replacement of the && operators with and. I don't use and and I couldn't find anywhere in Laravel's codebase where it was used either. If you change these back to &&, then I'll merge in the request.

Thanks for doing this by the way, I've been going though a lot of my old code and fixing it as well :-)

billmn commented 9 years ago

I can fix this tonight ;)

billmn commented 9 years ago

Done ... already merged with latest commits

Torann commented 9 years ago

Super! Thanks