Closed billmn closed 9 years ago
+1, this is important for contributors to easily pick up the code.
+1 for coding style :)
Everything in the pull request looks great. I did this back before I started following the coding style more closely. My only reason for not merging the request is the replacement of the &&
operators with and
. I don't use and
and I couldn't find anywhere in Laravel's codebase where it was used either. If you change these back to &&
, then I'll merge in the request.
Thanks for doing this by the way, I've been going though a lot of my old code and fixing it as well :-)
I can fix this tonight ;)
Done ... already merged with latest commits
Super! Thanks
Fixed Laravel Coding Style and a missing "return" in getCurrencySymbol()