search

Torann / laravel-currency

This provides Laravel with currency functions such as currency formatting and conversion using up-to-date exchange rates.
http://lyften.com/projects/laravel-currency
BSD 2-Clause "Simplified" License
392 stars 137 forks source link

Default Currency not working? #22

Closed hgeorgilas closed 7 years ago

hgeorgilas commented 9 years ago

Hello, I used this package to display currencies for an ecomm site but the default settings I use are not working. I made EUR the default currency in the config.php, but my currency always displays as USD. I have to use EUR as the second parameter in the function to display my currency as EUR. I've also tried the currency:cleanup and currency:update commands with no success. Don't know if it's a real problem, but I thought I should submit it. Thanks.

SilverPaladin commented 9 years ago

I also notice a problem. I had initially set my default currency to 'CAD' and then noticed that my output was actually converted from USD to CAD and my numbers where all messed up. I figured OK, I'll use 'USD' as my default so that the output is multiplied by 1.000 instead of the exchange rate, but still I get the calculated exchange to Canadian value unless I specify the currency to 'USD' in my blade template. Funny thing is, I only need to specify on one single value, even though I have 30 values on the page to display. This package needs to be extended so that the home currency is zero, and the output currency is exchanged only if a different currency from the home currency is output.

PS. I really am just using this package to format my output. Would be great if we could turn off the exchange rate features in config.

Torann commented 8 years ago

Not sure what was going on here. I can't reproduce this.

FiloSpaTeam commented 8 years ago

The problem is that: i'm italian and our currency is EUR. But if you set EUR in default config you don't really work with EUR, but with USD converted in EUR.

Example: I saved in database 1000.00 (numeric value). If i use EUR as default, those are 1000.00 Euro, if i use USD as default, those are 1000.00 USD,

now, if i set EUR as default but get them as USD, we have 1000 * 0,89 = 890 Euro 1000 is not 890.

Torann commented 7 years ago

This is fixed in the upcoming version 1.0 release