search

Torann / laravel-currency

This provides Laravel with currency functions such as currency formatting and conversion using up-to-date exchange rates.
http://lyften.com/projects/laravel-currency
BSD 2-Clause "Simplified" License
392 stars 137 forks source link

Bug fixed for Laravel 5.1 #53

Closed umbertix closed 7 years ago

umbertix commented 7 years ago

[#51], [#52]. Incompatibility found with laravel 5.1.

umbertix commented 7 years ago

I think that making the conversion format the return by default is incorrect. A function should do what it says and only what it says. I would not expect a conversion function to format my amount. To keep the backwards compatibility I suggest just adding a new parameter to give a bit more of flexibility to people.

Torann commented 7 years ago

I'm moving this into a ghetto hotfix. There are a few things that need to be fixed/simplified in your pull request. Thanks!!!