added google finance option and ftehc method

Torann / laravel-currency

This provides Laravel with currency functions such as currency formatting and conversion using up-to-date exchange rates.

http://lyften.com/projects/laravel-currency

BSD 2-Clause "Simplified" License

395 stars 136 forks source link

Closed joe-pritchard closed 6 years ago

joe-pritchard commented 7 years ago

Added method for google finance, and command line option -g, or --google

joe-pritchard commented 6 years ago

@Torann , have a chance to look at this? I have something else I'd like to add once this is merged :)

Torann commented 6 years ago

Looks good! Left comments about some super minor tweaks.

Google isn't dropping this anytime soon are they?

joe-pritchard commented 6 years ago

Completely forgot about this, sorry. Changes done as requested :)

I can't see Google removing finance any time soon I think its quite widely used...

joe-pritchard commented 6 years ago

Hi mate - just a bump; I'm actively using the google finance option in my project and I'd like to get back on the main fork :)

Torann commented 6 years ago

Looks good!