search

Torann / laravel-geoip

Determine the geographical location of website visitors based on their IP addresses.
http://lyften.com/projects/laravel-geoip
BSD 2-Clause "Simplified" License
2.07k stars 372 forks source link

Move phpdotenv to require-dev in composer.json to allow installations on Laravel 5.8 #166

Closed ncla closed 4 years ago

ncla commented 4 years ago

This commit introduced the dependency https://github.com/Torann/laravel-geoip/commit/8f3b596964155fc707be5fdb9022612b87f18c0f and if it's a dev dependency I think it should be moved to required-dev section. The commit message says it's needed for unit tests.

Otherwise can't seem to install this package on Laravel 5.8 as it is locked to ^3.3 version for phpdotenv https://github.com/laravel/framework/blob/5.8/composer.json#L43

Composer require throws this:

  Problem 1
    - Installation request for torann/geoip ^1.1 -> satisfiable by torann/geoip[1.1.0].
    - Conclusion: remove vlucas/phpdotenv v3.4.0
    - Conclusion: don't install vlucas/phpdotenv v3.4.0
    - torann/geoip 1.1.0 requires vlucas/phpdotenv ^3.5 -> satisfiable by vlucas/phpdotenv[v3.5.0, v3.6.0].
    - Can only install one of: vlucas/phpdotenv[v3.5.0, v3.4.0].
    - Can only install one of: vlucas/phpdotenv[v3.6.0, v3.4.0].
    - Installation request for vlucas/phpdotenv (locked at v3.4.0) -> satisfiable by vlucas/phpdotenv[v3.4.0].
AidasK commented 4 years ago

Would be nice to have this one merged asap :)

stevewolfe555 commented 4 years ago

This is needed for Laravel 5.7 also.

robciaccio commented 4 years ago

Laravel 5.5 as well - @Torann this wouldn't be a big deal except we have to update this library because of the changes by maxmind at the end of the year to the free database. So unfortunately we can not use geoip or even deploy our application (it will break all geoip functionality) until this is merged :/

Torann commented 4 years ago

Ugh good catch