Torann / laravel-geoip

Determine the geographical location of website visitors based on their IP addresses.
http://lyften.com/projects/laravel-geoip
BSD 2-Clause "Simplified" License
2.1k stars 373 forks source link

Default cache TTL only 30 seconds? (Laravel 5.8 changed TTL units) #184

Open chuck-wood opened 4 years ago

chuck-wood commented 4 years ago

In Laravel 5.8, the cache item time-to-live changed from minutes to seconds.

The default cache TTL in GeoIP is "30":

I presume this was supposed to be 30 minutes, not 30 seconds? The unit is not specified in the documentation, which would be useful either way.

Recommended fix: change 30 in the above locations to 1800.