Allow dependency injection

[KaliaJS]

Allow dependency injection. To avoid using a global variable.

    use Torann\GeoIP\GeoIP;

    public function login(GeoIP $geoip)
    {
        return $geoip->getLocation($request->ip())->toArray();
    }

[KaliaJS]

@Torann What do you think ?

[Torann]

Nice but it breaks the helper. Also I don't really see the need, why not use the helper? geoip()

[KaliaJS]

@Torann I avoid global variables as much as possible. For me it's a bad practice (sometimes it's inevitable). I submit a new commit with the correction for the break and in addition I added a deferred to the service provider.

[KaliaJS]

@Torann ??

[Torann]

Sorry I just don't see a benefit to this. The helper is not a global variable, it's a function and this method is pretty common practice. I would recommend if you don't care for using it then to continue using your fork in your projects. Also in your fork you can completely remove the helper function and do as you please :-)

[KaliaJS]

@Torann No problem