Launch TorchBase in separate app domain

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!

Apache License 2.0

146 stars 76 forks source link

Launch TorchBase in separate app domain #128

Closed Equinox- closed 7 years ago

Equinox- commented 7 years ago

Issues with types being loaded twice, etc cause problems.

[ ] Launch TorchBase using a separate AppDomain than the Program launchers use
[ ] Look into ensuring that these things don't load a different assembly then this thing.
[x] Use PrivateBinPath
[ ] Investigate why tests seem to break

iambenmitchell commented 7 years ago

Is there a temp fix?

Equinox- commented 7 years ago

No, but this is my highest priority ATM. Should be patched in the next 24h

On Oct 4, 2017 09:36, "MrBenFTW" notifications@github.com wrote:

Is there a temp fix?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/TorchAPI/Torch/issues/128#issuecomment-334196715, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs7OERymmdW6KIFaDImnT-I42jHTAznks5so6XmgaJpZM4PpP8x .

iambenmitchell commented 7 years ago

Thanks!

Equinox- commented 7 years ago

@MrBenFTW when you get a chance try this version of torch: https://build.torchapi.net/job/Torch/job/Torch/job/app_domains/lastSuccessfulBuild/artifact/

iambenmitchell commented 7 years ago

Okay

Equinox- commented 7 years ago

Fixed in https://build.torchapi.net/job/Torch/job/Torch/job/app_domains/ Will be merged into master as part of Torch v1.3.0