search

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

!restart works intermittently in the chat bar #212

Closed Inoram closed 2 years ago

Inoram commented 6 years ago

I was waiting until I report this one to try to get better information, but I really don't have any. Sometimes !restart works and sometimes after the !restart Torch just sits there not doing anything. No error, nothing.

I have seen it with !restart, !restart 20, !restart 600.

I am not sure if this is the same as if run in the AutoCommands, I have not tried that yet.

Torch v1.3.0.27-49-ge72f5b7 Essentials v1.7.0.13-4-g83ada5b

no other plug ins

Murllin commented 6 years ago

I’ve seen it do this as well I’m curious how long have you waited and watched it to see what it does. My server will have a good minute or two of nothing but then it will eventually close out all the grids and stop. But it’s almost as if it’s haveing trouble removing any current players from the world. My server has about 900 grids and 7000 asteroids so it takes some time to shut down.

Inoram commented 6 years ago

3-5 minutes roughly. ~200 grids.~450 asteroids, no players.

Murllin commented 6 years ago

So it closes after 3-5 minutes or you lose patience and exit out after 3-5 minutes?

Inoram commented 6 years ago

Lose patience.

Inoram commented 6 years ago

I tried it again, it sat for 11 minutes and then someone joined and it appeared like someone joining triggered it to restart. Server was empty until that person joined.

Cabub commented 6 years ago

I've also got this issue as well, my suspicion is that the command won't run while the server is paused, and you have the config 'Pause When Empty' turned on, as I do. I can run without that config today and report my findings.

Cabub commented 6 years ago

Update: This seems to be the issue, I turned off 'Pause when empty' let the autocommand "!restart" come around, and it restarted even though there wasn't a player in-game. So I'd say the bug is really that !restart only triggers a restart if the game isn't paused.

Jimmacle commented 6 years ago

Hm, I guess that option completely pauses the update loop so when we invoke code on the game thread it never gets to it until someone joins the server. I can't think of an easy fix at the moment but if you're running Concealment the server is effectively paused when nobody is online anyway so you might be able to avoid using the option until we figure it out.