Instance is not initialized before plugins, leading to unexpected missing paths in plugins. - Githubissues

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!

Apache License 2.0

146 stars 76 forks source link

Instance is not initialized before plugins, leading to unexpected missing paths in plugins. #235

Closed Jimmacle closed 5 years ago

Jimmacle commented 6 years ago

Torch Version: v1.3.0.43-85-g9286f2e SE Version: 1.186.500

Expected Behavior

New instance to be generated and the server initialized normally

Observed Behavior

Essentials threw an exception attempting to load its config because the configured instance directory hadn't been created yet.

Steps to Reproduce

Ensure a plugin that uses the instance directory is installed like Essentials
Change the instance path to a new directory in Torch.cfg
Start the server

Fix

Ensure InstanceManager.LoadInstance() is called before the plugin manager is initialized.

Jimmacle commented 5 years ago

Fixed https://github.com/TorchAPI/Torch/commit/3f803b8107bcc16516662f024af8ecd3ac6032e5