search

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

[bug] missing plugin in torch.cfg causes other plugins to be skipped as well #321

Closed LordTylus closed 5 years ago

LordTylus commented 5 years ago

Torch Version: 1.3.1.60 SE Version: 1.191.106

Expected Behavior

If I disable a plugin using the torch cfg and dont delete the plugin from the plugins folder it will just be ignored.

Observed Behavior

If I remove a plugin from the torch cfg but dont remove the plugin from the plugin folder torch will load all plugins till it reached that one thats not in the cfg

And skips ALL other plugins after that as well

BTW this is something a lot of users seem to be having on discord help recently maybe we could somehow make the info which zips were skipped in the UI as well and not only the logs?

Steps to Reproduce

  1. Install a Bunch of Plugins
  2. Remove one of them that is in the folder pretty high up
  3. restart server and notice your plugin list is only a fraction of what is was before.

Other Information

My Plugins

    <guid>77333d2e-0571-4a07-ae58-5a81b9832265</guid>
    <guid>b3e6b485-3196-457e-9f12-46a6445ff887</guid>
    <guid>4c7fcdbd-fab3-4dc0-be0d-a49e79108fef</guid>
    <guid>223bab51-ce22-48a7-9b6f-3c37e5da37a2</guid>
    <guid>480afc34-87df-4fff-a2b5-82048e456ced</guid>
    <guid>370c6d2e-c2db-4eb2-a04f-49c9ee89dd2b</guid>
    <guid>333ccc73-02b8-45ec-9a8e-a3d68ed9c421</guid>
    <guid>894d12eb-68e1-4eaa-b8c2-263f004629d7</guid>
    <guid>17f44521-b77a-4e85-810f-ee73311cf75d</guid>
    <guid>de932be3-9f1d-40ce-8044-fc06dc48195e</guid>
    <guid>cbfdd6ab-4cda-4544-a201-f73efa3d46c0</guid>
    <guid>c1905f3f-86ac-4c54-96d2-32f71f677f6e</guid>
    <guid>682ca477-146c-40e0-a862-a2dc0f4bf631</guid>
    <guid>2741c395-dfb4-44c1-a937-836f9dd11f4c</guid>
    <guid>f9470106-fad3-468f-ad60-82371c4764d3</guid>
    <guid>da82de0f-9d2f-4571-af1c-88c7921bc063</guid>
    <guid>3cd3ba7f-c47c-4efe-8cf1-bd3f618f5b9c</guid>

Log with that

23:48:29.8727 [INFO]   PluginManager: Checking for plugin updates...
23:48:30.0945 [INFO]   PluginManager: Updated 0 plugins.
23:48:30.0945 [INFO]   PluginManager: Loading plugins...
23:48:30.1191 [INFO]   PluginManager: Loading plugin at ALE_BanNotifier.BanPlugin
23:48:30.1191 [INFO]   PluginManager: Loading plugin 'ALE Ban Notifier' (v1.0.0.0)
23:48:30.1287 [INFO]   PluginManager: Loading plugin at ALE_Biggest_Grids_Broadcast.GridsBroadcastPlugin
23:48:30.1287 [INFO]   PluginManager: Loading plugin 'ALE Grid Broadcaster' (v1.0.1.2)
23:48:30.1287 [INFO]   PluginManager: Loading plugin at ALE_NoIdle.NoIdlePlugin
23:48:30.1287 [INFO]   PluginManager: Loading plugin 'ALE NoIdle' (v1.0.0.0)
23:48:30.1287 [INFO]   PluginManager: Loading plugin at ALE_Ownership_Logger.OwnershipLoggerPlugin
23:48:30.1287 [INFO]   PluginManager: Loading plugin 'ALE Ownership Logger' (v1.0.0.5)
23:48:30.1444 [INFO]   PluginManager: Loading plugin at ALE_GridManager.GridManagerPlugin
23:48:30.1444 [INFO]   PluginManager: Loading plugin 'ALE PCU Transferrer' (v1.1.2.1)
23:48:30.1444 [INFO]   PluginManager: Loading plugin at ALE_RestartWatchdog.RestartPlugin
23:48:30.1444 [INFO]   PluginManager: Loading plugin 'ALE Restart Watchdog' (v1.0.1.1)
23:48:30.1444 [INFO]   PluginManager: Loading plugin at ALE_Rotorgun_Detection.RotorgunDetectorPlugin
23:48:30.1444 [INFO]   PluginManager: Loading plugin 'ALE Rotorgun Detector' (v1.0.0.4)
23:48:30.1444 [INFO]   PluginManager: Loading plugin at ALE_ShipFixer.ShipFixerPlugin
23:48:30.1444 [INFO]   PluginManager: Loading plugin 'ALE ShipFixer' (v1.0.2.5)
23:48:30.1661 [INFO]   PluginManager: Loading plugin at Concealment.ConcealmentPlugin
23:48:30.1661 [INFO]   PluginManager: Loading plugin 'Concealment' (v1.4.1.9-6-gacfffc7)
23:48:30.1661 [INFO]   PluginManager: Loading plugin at EntityDeleteTracker.TrackerPlugin
23:48:30.1661 [INFO]   PluginManager: Loading plugin 'EntityDeleteTracker' (v1.0.0.1)
23:48:30.1883 [INFO]   PluginManager: Loading plugin at Essentials.EssentialsPlugin
23:48:30.1883 [INFO]   PluginManager: Loading plugin 'Essentials' (v1.7.1.35-98-g4659b9d)
23:48:30.1923 [INFO]   PluginManager: Loading plugin at HaE_PBLimiter.PBLimiter_Logic
23:48:30.1923 [INFO]   PluginManager: Loading plugin 'HaE PBLimiter' (v1.0.9.4)
23:48:30.1923 [INFO]   PluginManager: Loading plugin at HaE_TorchHackFix.HaETorchHackFix
23:48:30.1923 [INFO]   PluginManager: Loading plugin 'HaE TorchHackFix' (v1.0.4.0)
23:48:30.1923 [INFO]   PluginManager: Loading plugin at NoFSPluginNs.NoFSPlugin
23:48:30.1923 [INFO]   PluginManager: Loading plugin 'FoogsNoFamilySharing' (1)
23:48:30.1923 [INFO]   PluginManager: Loading plugin at PerformanceTweaker.TweakerPlugin
23:48:30.1923 [INFO]   PluginManager: Loading plugin 'PerformanceTweaker' (1.0.5)
23:48:30.3550 [INFO]   PluginManager: Loading plugin at Profiler.ProfilerPlugin
23:48:30.3550 [INFO]   PluginManager: Loading plugin 'Profiler' (v2.0.2.3-5-gec05893)
23:48:30.4457 [INFO]   PluginManager: Loading plugin at SEDiscordBridge.SEDiscordBridgePlugin
23:48:30.4457 [INFO]   PluginManager: Loading plugin 'SEDiscordBridge' (v1.5.6)

Logs after removing entry 370c6d2e-c2db-4eb2-a04f-49c9ee89dd2b

23:57:19.4436 [INFO]   PluginManager: Checking for plugin updates...
23:57:19.6555 [INFO]   PluginManager: Updated 0 plugins.
23:57:19.6555 [INFO]   PluginManager: Loading plugins...
23:57:19.6693 [INFO]   PluginManager: Loading plugin at ALE_BanNotifier.BanPlugin
23:57:19.6693 [INFO]   PluginManager: Loading plugin 'ALE Ban Notifier' (v1.0.0.0)
23:57:19.6791 [INFO]   PluginManager: Loading plugin at ALE_Biggest_Grids_Broadcast.GridsBroadcastPlugin
23:57:19.6791 [INFO]   PluginManager: Loading plugin 'ALE Grid Broadcaster' (v1.0.1.2)
23:57:19.6791 [INFO]   PluginManager: Loading plugin at ALE_NoIdle.NoIdlePlugin
23:57:19.6791 [INFO]   PluginManager: Loading plugin 'ALE NoIdle' (v1.0.0.0)
23:57:19.6791 [INFO]   PluginManager: Loading plugin at ALE_Ownership_Logger.OwnershipLoggerPlugin
23:57:19.6791 [INFO]   PluginManager: Loading plugin 'ALE Ownership Logger' (v1.0.0.5)
23:57:19.6949 [INFO]   PluginManager: Loading plugin at ALE_GridManager.GridManagerPlugin
23:57:19.6949 [INFO]   PluginManager: Loading plugin 'ALE PCU Transferrer' (v1.1.2.1)
23:57:19.6949 [WARN]   PluginManager: Plugin ALE Restart Watchdog (E:\SE\Space Engineers\Server\torch-server\Plugins\ale-restartwatchdog.zip) exists in the plugin directory, but is not listed in torch.cfg. Skipping load!

Quite a lot missing

rexxar-tc commented 5 years ago

Should have been fixed some time ago. Reopen if it's still an issue

LordTylus commented 5 years ago

Just tested on the latest build 1.3.1.60-master with SE 1.191.106 issue still present

Steps to reproduce still apply