As a Plugin Developer, I want to unload my commands or command module, so that gives me the opportunity to create my plugin features toggles - Githubissues

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!

Apache License 2.0

146 stars 76 forks source link

As a Plugin Developer, I want to unload my commands or command module, so that gives me the opportunity to create my plugin features toggles #339

Closed szczepix closed 2 years ago

szczepix commented 5 years ago

[x] Verify that this issue is related to Torch and not a Torch plugin or the vanilla game
[x] Ensure that the issue is reproducible for testing (provide a link to a test world if necessary)
[x] Is this a suggestion?

Torch Version: 1.3.1.76-master SE Version: 1.192.22

Expected Behavior

I can unload my plugin commands or command module.

Observed Behavior

public void UnregisterPluginCommands(ITorchPlugin plugin)
{
    // TODO
}

Steps to Reproduce

Try UnregisterPluginCommands method from CommandManager class in Torch.Commands namespace.

Other Information

https://github.com/unitycontainer/unity

LordTylus commented 5 years ago

Very excellent Idea,

I myself am thinking of moving some commands over to a different plugin so my idea would be to leave the commands for backwards compatibility in the old plugin

that just says "hey this command was moved over to an other plugin, please install this instead"

so that I can when I detect that plugin just bind the new commands instead.