search

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

[Feature request: Torch 1.0.180.471, SE 1.181.400] Changed from BUG! Critical mod error does not have appropriate logging #36

Closed Varaxian closed 6 years ago

Varaxian commented 7 years ago

Torch 1.0.180.471, SE 1.181.400

Description:

When a mod has a critical error, no feedback is given to console as to why the server is shutting down or exiting and may cause hours of investigation and bad bug reports!

Expected Behavior

When mod with critical error found, some log of said error.

Observed Behavior

Torch exits and server stops.

Steps to Reproduce

(Reproduction steps not solid due to lack of log)

  1. Break a mod
  2. Forget to remove mod from mod list
  3. Enjoy the failcascade

Other Information

https://pastebin.com/nUPHzbs4 Torch.log https://pastebin.com/c4gYFNDt Console

Varaxian commented 7 years ago

Update: Deleting essentials mod does NOT resolve the issue.

2017-06-30 03:10:26.944: Loading session: C:\ProgramData\SpaceEngineersDedicated\Virgo System\Saves\Virgo System 2017-06-30 03:10:40.4613 [INFO] Config: Saved DS config. 2017-06-30 03:10:41.5744 [INFO] Config: Saved world config. 2017-06-30 03:12:05.907: Exception while loading world: One or more errors occurred. 2017-06-30 03:12:05.9257 [INFO] CommandManager: Registering command 'help' 2017-06-30 03:12:05.9257 [INFO] CommandManager: Registering command 'ver' 2017-06-30 03:12:05.9257 [INFO] CommandManager: Registering command 'plugins' 2017-06-30 03:12:05.9427 [INFO] CommandManager: Registering command 'stop' 2017-06-30 03:12:05.9587 [INFO] PluginManager: Downloading plugins 2017-06-30 03:12:05.9587 [INFO] PluginManager: Checking for updates for C:\Program Files (x86)\TORCH\Plugins\Concealment 2017-06-30 03:12:05.9992 [INFO] PluginUpdater: Checking for update at TorchAPI/Concealment 2017-06-30 03:12:06.5022 [INFO] PluginUpdater: TorchAPI/Concealment is up to date. 2017-06-30 03:12:06.5022 [INFO] PluginManager: Loading plugins 2017-06-30 03:12:06.5177 [INFO] PluginManager: Loading plugin Concealment (1.1.2) 2017-06-30 03:12:06.5177 [INFO] CommandManager: Registering command 'conceal' 2017-06-30 03:12:06.5177 [INFO] CommandManager: Registering command 'reveal' 2017-06-30 03:12:06.5357 [INFO] CommandManager: Registering command 'reveal.all' 2017-06-30 03:12:06.784: Exiting.. infinario [Debug]: Batch executed, 1 enqueued, 1 processed, 0 failed, rest was told to retry 2017-06-30 03:12:07.723: Autosave in unload 2017-06-30 03:12:07.980: Logging off Steam... 2017-06-30 03:12:07.980: Shutting down server... 2017-06-30 03:12:08.076: Done

Jimmacle commented 7 years ago

This isn't really a Torch issue (the vanilla game does the same thing) but I'll see what I can do about getting some logging in there.

Varaxian commented 7 years ago

Agreed. I tested with SESE and that's how I found the issue because it pointed to the appropriate log file. Low priority for the future. I thought it was a bug originally

On Jun 30, 2017 11:21 AM, "John Michael Gross" notifications@github.com wrote:

This isn't really a Torch issue (the vanilla game does the same thing) but I'll see what I can do about getting some logging in there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TorchAPI/Torch/issues/36#issuecomment-312311750, or mute the thread https://github.com/notifications/unsubscribe-auth/AXurF8AWdegykBxVJDclcJflhXXM8T_Zks5sJSCfgaJpZM4OKRDg .

Jimmacle commented 6 years ago

This should be taken care of now that the Keen logger is intercepted.