TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

Configuration option to disable DS update before starting the server #363

Closed viktor-ferenczi closed 4 years ago

viktor-ferenczi commented 4 years ago

Torch Version: 1.3.1.99 SE Version: 1.193.103

Whenever Torch starts the SE dedicated server it forces an update in Initializer.RunSteamCmd:

log.Info("Checking for DS updates.");

In the case of the system we built ( https://spacewar.se ) we run new dedicated servers based on player needs and recycle unused lobbies periodically. It causes a lot of DS updates, which tend to fail or take too long due to Steam being slow at processing requests from time to time. We are not throttled or limited in any way, it is just due to temporary problems on Steam's side.

I suggest adding a configuration option to Torch.cfg to disable the DS update. It could be done by adding such an option and simply making the related code block conditional.

Updates would be done by periodically updating the DS image we clone before starting each server.

Default behavior would be the current one, e.g. updating each time before starting the DS.

Jimmacle commented 4 years ago

It does look like we're missing an option to specifically disable vanilla DS file updates. You can use the -noupdate command line argument for now to disable updating all components. The next major update of Torch will improve the update checking process and not require waiting for SteamCMD to complete each launch.

viktor-ferenczi commented 4 years ago

Thank you for the suggestion. My bad, actually. I passed -NoUpdate instead of -noupdate. I'm changing it now, hopefully it will help.

viktor-ferenczi commented 4 years ago

Passing -noupdate helped, no DS update is attempted anymore.

BTW, Torch does not report unknown command line parameters, it just silently ignores them. This is okay, but error prone.

Jimmacle commented 4 years ago

That should be fixed in the next big update as well since we'll be using a third party library to handle command line input.

szczepix commented 4 years ago

What is a The next major update of Torch or next big update @Jimmacle ? Torch 2 is comming... ?