TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

Torch not always starting SE instance after a !restart or crash recovery #388

Closed kontu closed 2 years ago

kontu commented 4 years ago

Torch Version: 1.3.1.120-Master SE Version: 1.194.211

Expected Behavior

What did you expect to happen? SE instance to stop (or crash), torch to close, torch to re-open, and torch to start the SE instance again

Observed Behavior

What actually happened? SE instance stops (or crashes), torch closes, torch re-opens, and torch does NOT start the SE instance again. Torch is open waiting user input clicking "Start"

Steps to Reproduce

  1. Randomly occurs some of the time on any of our 9 torch instances after a essentials autocommand !restart 1b. Randomly occurs some of the time on any of our 9 torch instances after a instance crash ( true is set on all instances)

Other Information

Logs from two separate instances

Server !restart at 1200 ST; just sat there waiting to have "Start" pressed no_start.zip

Different torch instance; server crashed at 1656; torch restarted but never "started" server; start was pressed manually at 1830 nostart_2.zip

SinisterSole commented 4 years ago

If "Torch is open waiting user input clicking "Start"" happens on all instances, you need to set autostart in Torch.cfg or at least check that it is set to true.

kontu commented 4 years ago

While you are correct that setting Autostart to true works as a bandaid workaround for this issue; that is not related to this issue report.

Out of 54 !restart commands a day, we would see it get stuck waiting for us to press start 1/75 restarts (so once every day and a half) roughly. Never reliably the same instance.