Closed ryo0ka closed 3 years ago
This looks nice, however it seems like a relatively standalone feature that would be better suited as a plugin. Is there any reason besides easy consumption that it should be merged into Torch itself?
@Jimmacle Actually no other reasons. This is just my best effort to share my server's tools for some other admins who want to try it but can't code/build by themselves.
I can turn this into a standalone plugin; it'll only take some tweaking to the libraries, in other words fighting the dependency and keeping it updated somehow. This PR's solution is dump it on MSBuild and call it a day. My defense argument is that the product is somewhat popular in the community and an "easy consumption" of the product is dreamed enough to justify the integration.
Closed as I implemented a standalone plugin
This PR adds dependency to
InfluxDB.Client
and some bridge classes for easy consumption by plugins such as TorchMonitor.Why InfluxDB?
Alternative choice of database: Elasticsearch can handle more types and schemes of data. Please ask Kontu's team. Our Torch fork does have Elasticsearch integrated as well (not included in this PR).
Why Integrate Database to Torch?
The admin community's strong interest toward a nice-looking monitoring dashboard. Easy access to database will be the first step forward to everyone's dream. Higher standard of understanding to the game and players shall enlighten our minds...🧙♂️