Solution fixes - Githubissues

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!

Apache License 2.0

146 stars 76 forks source link

Solution fixes #440

Closed rcdailey closed 3 years ago

rcdailey commented 3 years ago

Remove Torch.Client and corresponding tests from the solution. They aren't set to build with the solution anyway. Removing it from the solution:
- Makes it less confusing for new users: If I don't see it there, it's more clear to me that it isn't maintained or intended to be built
- Makes solutions load and perform better since there's less to deal with
- Code doesn't compile, so errors won't show up in my solution error list which again makes this less confusing for newcomers to the project.
Removed the AnyCPU solution configuration. This isn't used anywhere that I can find and isn't even configured properly. No point in having it.

rcdailey commented 3 years ago

For some context:

My primary goal is to make the chat text selectable. This is going to be a non-trivial amount of work. The secondary purpose of this PR (the first being that they are just good fixes) is to test the waters:

I'm concerned that developer activity here is very low. When I look over existing PRs, there is not a lot of activity and some are quite old. If I don't get much of a reasonable response from the developers for a simple PR like this, I will likely not bother contributing further work and time.

rcdailey commented 3 years ago

(Sorry did not mean to close the PR; I fat-fingered the wrong button)

Jimmacle commented 3 years ago

I've been busy with school and working on a plan for a major rewrite of the application and revamp of the development/contribution process so I haven't had much time to keep GitHub cleaned up. I'm active on the Discord server when possible which is where most contributor discussions take place. If you'd like you can remove the client-related projects entirely because I have no plans to resurrect it in this version of Torch and it's just there for future reference.

rcdailey commented 3 years ago

Closing this PR due to inactivity.