search

TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

Mods Not Saved #49

Closed kamikaze0310 closed 7 years ago

kamikaze0310 commented 7 years ago

Mods in torch gui is not saved when modified. I can manually go into SpaceEngineers-Dedicated.cfg and put the modID in and it works but any changes in torch GUI is unaffected to the cfg file.

Torch Version: 1.1.207.7 SE Version: 1.182.19

Expected Behavior

Any changes made in torch GUI in the mods section should reflect in SpaceEngineers-Dedicated.cfg

Observed Behavior

Changes were made to torch GUI but were not saved in SpaceEngineers-Dedicated.cfg

haximodor92 commented 7 years ago

Yeah I have the same problem here, seems like a issue with 1.1.207.7

Varaxian commented 7 years ago

Confirmed. GUI is broken

Jimmacle commented 7 years ago

This should be fixed in the update released today.

finne132 commented 7 years ago

@Jimmacle This appears to still be an issue as of today. https://github.com/TorchAPI/Torch/issues/64 was opened up 2 days ago and appears to be a duplicate of this with an added mention of the admins field also not saving.

@kamikaze0310 Can you help clue me in to the workaround you are using to launch the server WITH mods? Every time I start the server through Torch after having manually added the mods to the CFG file, Torch overwrites my changes before the server launches and no mods are ever loaded.

Still playing with it to find a workaround myself

kamikaze0310 commented 7 years ago

@finne132 BEFORE you start torch, edit the CFG file and add the modID number to it. 

<Mods>
   < unsignedLong>932957557</unsignedLong>
   < unsignedLong>316190120</unsignedLong>
   < unsignedLong>644104483</unsignedLong>
   < unsignedLong>670717906</unsignedLong>
   < unsignedLong>487874776</unsignedLong>
   < unsignedLong>865309539</unsignedLong>
 </Mods>

Then I launched torch and the Mods fields in torch GUI is reflected to what I have in this CFG file. Not sure if your doing it any different?

Jimmacle commented 7 years ago

Are you clicking "Save Config?"

kamikaze0310 commented 7 years ago

@Jimmacle you mentioned that this is fixed on latest build...I actually having tested it since. Are u asking finne132?

Jimmacle commented 7 years ago

I'm asking anyone experiencing the issue. I forgot to have the config save when you click Start after refactoring the instance manager code so I need to know if it's simply not saving automatically or if it's actually failing to save. There's a button on the config tab to save it manually.

kamikaze0310 commented 7 years ago

@Jimmacle gotcha....just tested, I hit save with the MODS field empty and hit start and it still loaded the existing mods in the CFG file.

kamikaze0310 commented 7 years ago

untitled

Showing that it saves it...... 11:58:41.3388 [INFO] InstanceManager: Saved dedicated config. 11:58:42.2759 [INFO] InstanceManager: Saved world config. 11:59:53.0807 [INFO] InstanceManager: Saved dedicated config. 11:59:53.1717 [INFO] InstanceManager: Saved world config. 11:59:53.1822 [INFO] Torch: Starting server.

But yet mods will get loaded.... 2017-08-04 12:00:02.013 - Thread: 12 -> Downloading world mods - START 2017-08-04 12:00:02.040 - Thread: 12 -> Server connected to Steam 2017-08-04 12:00:02.041 - Thread: 12 -> Server PolicyResponse (1) 2017-08-04 12:00:02.355 - Thread: 12 -> HTTP: Downloaded 14627 bytes 2017-08-04 12:00:02.360 - Thread: 12 -> Up to date mod: id = 316190120 2017-08-04 12:00:02.361 - Thread: 12 -> Up to date mod: id = 487874776 2017-08-04 12:00:02.364 - Thread: 12 -> Up to date mod: id = 644104483 2017-08-04 12:00:02.365 - Thread: 12 -> Up to date mod: id = 670717906 2017-08-04 12:00:02.365 - Thread: 12 -> Up to date mod: id = 865309539 2017-08-04 12:00:02.366 - Thread: 12 -> Up to date mod: id = 932957557 2017-08-04 12:00:02.370 - Thread: 12 -> Downloading world mods - END

finne132 commented 7 years ago

@Jimmacle sorry for the delay, was in a meeting there - yes I have been making sure to click Save Config. So here's my entire process (I haven't done kamikaze's workaround yet of loading the mods into the cfg file first).

  1. open torch
  2. paste in mod list
  3. Click save ------no change to cfg where the mods would be inserted-------
  4. Launch server

The workaround I tried that failed was...

  1. open torch
  2. edit cfg file, insert mod tags manually
  3. save cfg file
  4. click to start server -----cfg file is overwritten, manually added mods tags are removed and server boots w/no mods----

I hope this is helpful. Going to try @kamikaze0310 method of adding mods to the cfg before launching now!

finne132 commented 7 years ago

@kamikaze0310 you are spot-on with your workaround thank you so much - works perfectly.

Jimmacle commented 7 years ago

Fixed 82815f66e5384b8e8427d50720e23aebd3e10da0

JemiloII commented 5 years ago

where is this suppose to be? The dedicated server? Some other cfg? I did a full search and don't see this anywhere.