TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

[Bug report]Torch will set the procedural density back to 0.25 automatically #55

Closed haximodor92 closed 7 years ago

haximodor92 commented 7 years ago

Torch Version: 1.0.182.329 SE Version: 1.182.102

Expected Behavior

What did you expect to happen? After I modify the sandbox.sbc file, the game should be the procedural density I modify.

Observed Behavior

What actually happened? Torch will automatically modify the sandbox.sbc file and set the procedural density back to 0.25 and procedural seed to 0.

Steps to Reproduce

  1. How did this issue get triggered?
  2. Write the steps here. 1)modify the sanbox.sbc, change the number of procedural density and seed to any number. 2)Click torch to open a server with the corresponding saves. 3)Open again the sanbox.sbc, you'll find the procedural density has been switched back.

Other Information

Provide links to game logs or saves here if necessary.

Varaxian commented 7 years ago

Interesting. I will verify reproduction for this. If it's happened, I've missed it myself

kurazarrh commented 7 years ago

What's happening here is that if you want to modify the procedural density or seed for an existing world, you need to change it both in the .sbc file, as well as in the SpaceEngineers-Dedicated.cfg file. If you don't change it in the .cfg file, then Torch will read the file and overwrite the .sbc file's settings when it saves.

Try changing it in both places and let us know if it is resolved.

Varaxian commented 7 years ago

And before you have a torch instance loaded. You can also use the vanilla configurator to do this in a GUI and save the files

On Jul 28, 2017 3:20 PM, "kurazarrh" notifications@github.com wrote:

What's happening here is that if you want to modify the procedural density or seed for an existing world, you need to change it both in the .sbc file, as well as in the SpaceEngineers-Dedicated.cfg file. If you don't change it in the .cfg file, then Torch will read the file and overwrite the .sbc file's settings when it saves.

Try changing it in both places and let us know if it is resolved.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TorchAPI/Torch/issues/55#issuecomment-318752506, or mute the thread https://github.com/notifications/unsubscribe-auth/AXurF75xDNUnieCBpfnOM0eWSPOPlgQNks5sSkJ_gaJpZM4Ol8DG .

Jimmacle commented 7 years ago

This should be fixed in 82815f66e5384b8e8427d50720e23aebd3e10da0, there was a bug with saving config changes.