TorchAPI / Torch

An extensible modding framework and improved client/DS for Space Engineers. Still a work in progress!
Apache License 2.0
146 stars 76 forks source link

[BUG] + [FR] - Torch does not taskkill TORCH process on crash causing a "No Save" scenario on start of new process. #60

Closed Varaxian closed 7 years ago

Varaxian commented 7 years ago

Torch Version: 1.1.207.7 SE Version: 1.182.103

Summary: In the event that TORCH crashes, RestartOnCrash enabled, Torch will start a new instance on-top of the currently crashed instance, therefor giving it no access to worldfiles and causing a "No Save" scenario.

Expected Behavior

Observed Behavior

Steps to Reproduce

(Not 100% repro, as the process does NOT always stick around on crash)

  1. Crash torch
  2. Note if Torch process remains running (regardless of GUI or Command Prompt being open) 3.) If so, launch new Torch 4.) Attempt to save 5.) Check world file modification timestamp

Feature request

Jimmacle commented 7 years ago

Fixed 2f3b6cdda7444d84604d209b1f5f02454e0d0ab3, the new Torch process should kill the old one if it doesn't exit in time.