TorchDSP / torchsig

TorchSig is an open-source signal processing machine learning toolkit based on the PyTorch data handling pipeline.
MIT License
170 stars 38 forks source link

OFDM modulator LPF is not randomized #97

Closed MattCarrickPL closed 1 year ago

MattCarrickPL commented 1 year ago

OFDM has a randomized LPF as part of the group of sidelobe suppression methods, however the cutoff is not randomized at all, only produces a value of 0.95:

        cutoff = np.random.uniform(0.95, 0.95)

via https://github.com/TorchDSP/torchsig/blob/main/torchsig/datasets/synthetic.py#L741

Is sidelobe_suppression_method == "rand_lpf" used? Should the np.random.uniform() call be changed to cover a larger range of values?