search

TorchlightSoftware / mongo-watch

Watches for changes in MongoDB replication log.
MIT License
95 stars 17 forks source link

Move native_parser option to Mongo's DB contructor #7

Closed mdlavin closed 10 years ago

mdlavin commented 10 years ago

The mongo docs for Server (http://mongodb.github.io/node-mongodb-native/api-generated/server.html) do not list native_parser as an option, but the docs for Db (http://mongodb.github.io/node-mongodb-native/api-generated/db.html) do.

This change moves the native_parser option to the class that is documented to support it.

bitmage commented 10 years ago

Sounds good. I used _.merge instead of the loop, but the new version 0.2.3 should support this behavior.

https://github.com/TorchlightSoftware/mongo-watch/commit/af654d069061decc0a75e801b5277565b0bc3494

mdlavin commented 10 years ago

The reason I used the loop instead of was because is listed as a dev time dependency not a production dependency. I wasn't sure if it was worth adding the dependency for something so simple. You might want to consider either taking my version or making a new change to the package.json file.

bitmage commented 10 years ago

Good catch! I updated the package.json to include the dependency. I tend to program with lodash out of habit, so it's probably better for it to be there. :-)

On Thu, May 1, 2014 at 9:59 AM, Matt Lavin notifications@github.com wrote:

The reason I used the loop instead of was because is listed as a dev time dependency not a production dependency. I wasn't sure if it was worth adding the dependency for something so simple. You might want to consider either taking my version or making a new change to the package.json file.

— Reply to this email directly or view it on GitHubhttps://github.com/TorchlightSoftware/mongo-watch/pull/7#issuecomment-41930072 .