DPS/HPS metrics are fucked

[Toreole]

For some (as of now unknown) reason, the dps sums in the single encounter view are very wrong. about 3-4% off from what its supposed to be. (For all intents and purposes, the overview/import dps is correct - within 0.02% margin of WCL on average)

overview	inspect	error %
82451,5	79949,7	-3,0343
76142,2	74346,1	-2,3589
75507,7	73597,3	-2,5301
90873,3	90018,7	-0,9404
80070,9	77658,7	-3,0126
83594,3	81377	-2,6525
74519,9	72574,4	-2,6107
78673,3	76187,8	-3,1593

Theres something going wrong in the dps calculation thats done in the encounter view source code. Needless to say: The goal here is not to temporarily fix the encounterview damage/healing calculation, but to rewrite this into one combined method that works for both import and inspection. After all, both should start out with the EncounterInfo object that is used to generate the dps totals.

[Toreole]

EDIT: BOTH the import dps calculation and the inspect one are fucked. https://www.warcraftlogs.com/reports/xbJHwZhRzTNpf1CQ#fight=last&type=damage-done comes out to 777.7k raid dps. This app comes out to 561.3K dps in both situations. I dont really remember changing anything, it used to work fine

[Toreole]

update: oh wow the updated TryParsePrefixSuffix method is malfunctioning

[Toreole]

Okay yeah that was it. Idk how i just forgot running the tests